Use the STATIC_URL for static files to avoid redirection #4522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Aug 15, 2018
| @@ -79,7 +76,7 @@ context = { | |||
| 'html_theme': html_theme, | |||
| 'current_version': "{{ version.verbose_name }}", | |||
| 'version_slug': "{{ version.slug }}", | |||
| 'MEDIA_URL': "{{ settings.MEDIA_URL }}", | |||
There was a problem hiding this comment.
We should probably continue to pass this along, in case anyone else is depending on it.
There was a problem hiding this comment.
In case we keep passing it, may be a good idea to have a comment saying that it's not need and should be removed but it's kept for compatibility reasons.
BTW, how we "deprecate" and communicate something like this? It's too small to worth a blog post, I think.
There was a problem hiding this comment.
I'll update this to keep the MEDIA_URL. I think we'll just keep it and detail any deprecation as part of https://docs.readthedocs.io/en/latest/design/theme-context.html.
- This may be removed when the new theme context is implemented https://docs.readthedocs.io/en/latest/design/theme-context.html
|
I re-added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a few areas that were using
MEDIA_URLbut really should be usingSTATIC_URLafter #4489. The old URL will work but will result in a redirect which slows things down and results in an extra hit.