Only use HostHeaderSSLAdapter for SSL/HTTPS connections #4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Aug 8, 2018
There was a problem hiding this comment.
I'm 👍 with these changes.
I'm not sure if it's not good to expand a bit more the situation. Maybe not in the comment, but in the commit/PR description mentioning the assert_hostname kw and the difference that you found around HTTPSConnectionPool and HTTPConnectionPool.
agjohnson
reviewed
Aug 8, 2018
readthedocs/restapi/client.py
Outdated
| host_header_ssl.HostHeaderSSLAdapter( | ||
| max_retries=3, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
max_retries was from the original adapter, we should add this with the standard http adapter if the connection is not ssl.
There was a problem hiding this comment.
That was not there prior to the PR that added the HostHeaderSSLAdapter. Do you think it is necessary to support retries in dev?
|
I re-added the default adapter class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made a mistake using
HostHeaderSSLAdaptereven when the connection wasn't HTTPS (in dev, that is). This causes problems connecting to the API.Fixes #4494