Replace old mimeparse package with python-mimeparse #4426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note! These packages occupy the same namespace. You might need to uninstall
mimeparse
and reinstallpython-mimeparse
.Refs #3570
Deployment notes
The old package
mimeparse
is not py3 compatible, butdjango-mailgun
brings in it's own dependency ofpython-mimeparse
, which is py3 compatible. This might not affect our RS cluster, but does affect our Azure cluster. Actions required on our Azure cluster were to manually removemimeparse
and installpython-mimeparse
, as these packages are forks and provide the same namespace. We aren't upgrading thedjango-mailgun
package here though, so might not be required for RS deployments.