Skip to content

Replace old mimeparse package with python-mimeparse #4426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jul 24, 2018

Note! These packages occupy the same namespace. You might need to uninstall
mimeparse and reinstall python-mimeparse.

Refs #3570

Deployment notes

The old package mimeparse is not py3 compatible, but django-mailgun brings in it's own dependency of python-mimeparse, which is py3 compatible. This might not affect our RS cluster, but does affect our Azure cluster. Actions required on our Azure cluster were to manually remove mimeparse and install python-mimeparse, as these packages are forks and provide the same namespace. We aren't upgrading the django-mailgun package here though, so might not be required for RS deployments.

Note! These packages occupy the same namespace. You might need to uninstall
`mimeparse` and reinstall `python-mimeparse`.
@agjohnson agjohnson requested a review from a team July 24, 2018 22:17
@agjohnson agjohnson added the Improvement Minor improvement to code label Jul 24, 2018
@agjohnson agjohnson added this to the Azure migration milestone Jul 24, 2018
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Reading the referenced issue seems that it doesn't fail on startup but by hitting a specific URL. It may be good to have a simple test that checks that URL (or a couple of similar) works, don't you think?

@agjohnson
Copy link
Contributor Author

Perhaps yeah. This was on sending an email. I'm not sure when i'll be able to get back to adding a test for this. maybe someone else can take it or we can create an issue for it.

@humitos
Copy link
Member

humitos commented Jul 26, 2018

There is no need to create a test or anything like that. The endpoint with the problem was deleted completely some time ago.

One thing I noticed is that python-mimeparse is not a dependency of our project (grepping the whole code looking for mimeparse gave me no results) so I'd say that we should completely remove python-mimeparse from our requirement.txt file and leave the dependency manager to solve it and install the one that it's required for the thirdparty library that needs it (tastypie or the one you found when sending emails)

@agjohnson
Copy link
Contributor Author

That makes more sense, yeah. I'll update here.

@humitos humitos merged commit 65d9759 into master Aug 14, 2018
@humitos humitos deleted the agj/replace-mimeparse branch August 14, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants