-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add Sponsors list to footer #4424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good to me. |
This looks good. I think it might be more useful to specify a bit more about what they are providing us. I really like what https://pypi.org/ does here: So we could do something like: Cloudflare |
I like Eric's proposal. We may want to include together with Cloudflare other services that we use (although, I'm not sure what's the contract we have with them: Azure, Sentry, New Relic, and maybe others that I'm missing here) |
My plan was to link to the upcoming blog post on the subject but I think I like your proposal better. |
I have updated this PR and edited the description. This PR was changed to add a number of sponsors to the footer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
I'll wait on merging this until we are a little closer to the Azure switchover date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
I suppose we can merge this PR. |
Edits: 2018-08-01
This PR got expanded (scope creeped) and now adds a number of sponsors to the footer.
Brand guidelines & assets
In general, I followed the following the below guidelines except I did desaturate any color if no black and white logo was provided.
Screenshot