Skip to content

Fix error in command #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Fix error in command #4345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion readthedocs/core/management/commands/update_repos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ class Command(BaseCommand):
help = __doc__

def add_arguments(self, parser):
parser.add_argument('slugs', nargs='+', type=str)

parser.add_argument(
'-r',
action='store_true',
Expand Down Expand Up @@ -56,7 +58,7 @@ def handle(self, *args, **options):
force = options['force']
version = options['version']
if args:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we need to check if options now instead of if args otherwise it fails in a weird way :)

for slug in args:
for slug in options['slugs']:
if version and version != "all":
log.info("Updating version %s for %s", version, slug)
for version in Version.objects.filter(project__slug=slug, slug=version):
Expand Down