-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update to Django 1.10 #4319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Django 1.10 #4319
Conversation
Looks like some changes were made to the |
Just to clarify in case anybody comes by and reads this, we are not using this in production. We are using PBKDF2 with 20k iterations. By upgrading to Django 1.10, this will change to 30k iterations whenever somebody logs in. |
I wonder if we can just make the API read-only using the This also feels like a nice way to slowly deprecate it. |
I'm trying that right now, seems to work. |
@ericholscher we only have this test for creating a project (for superusers only), I'm not sure if that is something we use https://github.com/rtfd/readthedocs.org/blob/d413341097466f90ca10eabadc347d35970847df/readthedocs/rtd_tests/tests/test_api.py#L420-L432 |
Don't believe so -- it is likely from when we used it from the builders in the past. |
Just noting here that we're targeting django 1.10 for our version 3.0, so i think we should probably back burner this project for right now. Our version 3.0 is probably a couple months out realistically, once we've wrapped up the yaml and search feature changes. |
e433bd1
to
e1e23ba
Compare
e1e23ba
to
3fcaade
Compare
This is the latest version of the 1.10.x series
3fcaade
to
c4dff93
Compare
Closes #4174
Things we need to check: