Skip to content

Refactor configuration object to class based #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 64 commits into from
Jul 10, 2018
Merged

Refactor configuration object to class based #4298

Show file tree
Hide file tree
Changes from 62 commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
8e6a73c
Create base class
stsewd Jun 25, 2018
10e750c
Use new interface for build.formats
stsewd Jun 25, 2018
0c7fdd8
Implement config.formats
stsewd Jun 25, 2018
3243d12
Linter
stsewd Jun 25, 2018
7799aa3
Test build.python
stsewd Jun 25, 2018
928dd7f
Implement build.python property
stsewd Jun 25, 2018
4c76ce4
Test buil.config property
stsewd Jun 25, 2018
bf055ca
Implement config.build property
stsewd Jun 25, 2018
37c67dd
Test for base and name properties
stsewd Jun 26, 2018
31076bf
Implement missing properties
stsewd Jun 26, 2018
81d0df9
Implement all abstract properties
stsewd Jun 26, 2018
baceda6
Remove setter
stsewd Jun 26, 2018
ea4b0fb
Move some logic from Wrapper object
stsewd Jun 26, 2018
666c952
Thinner Wrapper object
stsewd Jun 26, 2018
a6c18d5
Linter
stsewd Jun 26, 2018
5928a37
Remove output_base from dictionary
stsewd Jun 26, 2018
5d5c44a
Use build_image property
stsewd Jun 26, 2018
dcee59c
Use wrapper attribute
stsewd Jun 26, 2018
3c7bd9f
Use type attribute
stsewd Jun 26, 2018
fefe192
Use base attribute
stsewd Jun 26, 2018
33abd0d
Use python property
stsewd Jun 26, 2018
b49d0a2
Update docs
stsewd Jun 26, 2018
097b8fe
Use python property in wrapper
stsewd Jun 26, 2018
61756c3
Extra guard
stsewd Jun 26, 2018
e377829
Linter
stsewd Jun 26, 2018
cfb0b1d
Make config private
stsewd Jun 26, 2018
4cbc3c3
Use formats attribute
stsewd Jun 26, 2018
985ff7a
Use conda property
stsewd Jun 26, 2018
d0e9f78
Use requirements_file attribute
stsewd Jun 26, 2018
d48996d
Use conf_file attribute
stsewd Jun 26, 2018
2860205
Introducing defaults
stsewd Jun 26, 2018
2509235
Thinner wrapper
stsewd Jun 26, 2018
7f360b0
Don't use ConfigWrapper directly
stsewd Jun 26, 2018
259082f
Use defaults in formats
stsewd Jun 26, 2018
6e8f723
Use load_yaml_config inside PythonEnvironment
stsewd Jun 27, 2018
110ae38
Remove dict inheritance
stsewd Jun 27, 2018
ae20ca8
Test for ConfigNotSupportedError
stsewd Jun 29, 2018
23af026
Raise ConfigNotSupportedError when accessing a invalid attribute
stsewd Jun 29, 2018
668cb27
Test for validate
stsewd Jun 29, 2018
3604d50
Move version
stsewd Jun 29, 2018
c728680
Docs
stsewd Jun 29, 2018
6edf6f0
More tests
stsewd Jun 29, 2018
1b2014a
Remove try except
stsewd Jun 29, 2018
c19f0e0
More tests
stsewd Jun 29, 2018
1964317
Linter
stsewd Jun 29, 2018
fdad93d
Move _config to base class
stsewd Jul 5, 2018
89e0dcf
Implement default for use_system_site_packages
stsewd Jul 5, 2018
215206e
Typo
stsewd Jul 5, 2018
5c66206
Move build_image from ConfigWrapper
stsewd Jul 5, 2018
62a3d98
Move requirements_file from ConfigWrapper
stsewd Jul 5, 2018
711b595
Move python_version from ConfigWrapper
stsewd Jul 5, 2018
b43372b
Move python_full_version and python_interpreter from ConfigWrapper
stsewd Jul 5, 2018
e85e587
Pass build_image as default
stsewd Jul 6, 2018
376962e
Remove ConfigWrapper from tests
stsewd Jul 6, 2018
8d8197a
Goodbye ConfigWrapper
stsewd Jul 6, 2018
811bf72
Fix tests
stsewd Jul 6, 2018
241bbed
More tests
stsewd Jul 6, 2018
cdce197
Rename module
stsewd Jul 6, 2018
6ef45fe
Fix conflict
stsewd Jul 6, 2018
bc67350
Merge branch 'master' into move-configuration-to-class-based
stsewd Jul 6, 2018
8c516ba
Trailing comma
stsewd Jul 6, 2018
84bb4bc
Add TODOs
stsewd Jul 6, 2018
b8bba7e
Rename exception
stsewd Jul 9, 2018
b0bf8c5
Update copy
stsewd Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading