make it easier to use a different default theme

[xrmx]

This is for discussion more than inclusion. If this is sound we may want to do the same for default extensions. Our goal is to avoid the conf.py entirely in the documentation repos or make it very slim.

[ericholscher]

This looks like a reasonable change. I agree the theme should be set by a string that's passed in, instead of hard-coded. We'd want this to be configurable by a setting though, if we actually wanted it to be easily changed.

[xrmx]

Updated PR, haven't touched settings because we can update the context via the finalize_sphinx_context_data signal.

[xrmx]

ping

[humitos]

Thanks for your PR.

We'd want this to be configurable by a setting though, if we actually wanted it to be easily changed.

I suppose this is the only thing missing to be in a "ready to merge" state.

[xrmx]

@humitos can we please merge this as is and if someone want to expose this with a setting just do another PR? I don't have much bandwidth to work on this and I think the code duplication reduction is worth on its own.

[RichardLitt]

That might be a good 'Good First Issue' to open, too.

[ericholscher]

Tested this locally and it works well. Agreed the duplication is reason enough, and it can be changed via signal. 👍

[xrmx]

@ericholscher thank you very much for skimming these old PRs, much appreciated