Add tests for build json in html feature #4237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we really need to test this, as it's a short-lived deployment of a feature flip. We should really be testing the actual logic that is happening during the documentation build to get the JSON out with specific things (like unicode and sphinx domain objects). That is much harder to test though :) |
|
Got it, I don't think we have something like that in rtd, right? (only saw something like this in the rtd-extension repo) |
|
@stsewd yea, it's mostly tested in the extension, which is fine. I think we're mostly covered at this point, and then as we deploy it more widely, we'll see regressions (maybe not!) and then add tests to cover those cases. |
|
Got it, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing tests for #4229
I'll add some comments later.