Skip to content

Allow staff to trigger project builds #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions readthedocs/builds/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@

from django.shortcuts import get_object_or_404
from django.views.generic import ListView, DetailView
from django.http import HttpResponsePermanentRedirect, HttpResponseRedirect
from django.conf import settings
from django.http import (
HttpResponseForbidden,
HttpResponsePermanentRedirect,
HttpResponseRedirect,
)
from django.contrib.auth.decorators import login_required
from readthedocs.core.permissions import AdminPermission
from django.core.urlresolvers import reverse
from django.utils.decorators import method_decorator

Expand Down Expand Up @@ -38,10 +42,11 @@ class BuildTriggerMixin(object):

@method_decorator(login_required)
def post(self, request, project_slug):
project = get_object_or_404(
Project.objects.for_admin_user(self.request.user),
slug=project_slug
)
project = get_object_or_404(Project, slug=project_slug)

if not AdminPermission.is_admin(request.user, project):
return HttpResponseForbidden()

version_slug = request.POST.get('version_slug')
version = get_object_or_404(
Version,
Expand Down