-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Document that readthedocs file can now have yaml extension #4129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
89dd0e2
Update changes to the 'readthedocs' file extension happening in the r…
StefanoChiodino 0602425
Don't expand on the possible readthedocs file extensions.
StefanoChiodino dac21f8
Merge remote-tracking branch 'main/master'
StefanoChiodino 94f3698
Simplify how the config file is referred to.
StefanoChiodino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,8 +86,9 @@ The file format is based on the YAML spec 1.2 [#yaml-spec]_ | |
|
||
The file must be on the root directory of the repository, and must be named as: | ||
|
||
- ``.readthedocs.yml`` | ||
- ``readthedocs.yml`` | ||
- ``readthedocs.yaml`` | ||
- ``.readthedocs.yml`` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. List all possible options here. |
||
|
||
Conventions | ||
~~~~~~~~~~~ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ Read the Docs YAML Config | |
========================= | ||
|
||
Read the Docs now has support for configuring builds with a YAML file. | ||
The file, ``readthedocs.yml`` (or ``.readthedocs.yml``), must be in the root directory of your project. | ||
The file, ``readthedocs.yml``, ``.readthedocs.yml``, or ``readthedocs.yaml``, must be in the root directory of your project. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use only one file name here (the same than in the first paragraph) |
||
|
||
.. warning:: This feature is in a beta state. | ||
Please file an `issue`_ if you find anything wrong. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the link the to the yaml docs are fine here and we can just simplify this by
Read the Docs configuration file
or just.readthedocs.yml
. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Santos. We should mention just one possible option here and give more details below by listing all possible options as you have done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, should we go for
readthedocs.yml
here? Looks like the simplest option.