Skip to content

Handle general oauth services errors #4070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion readthedocs/oauth/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,17 @@ def run_public(self, user_id):
user = User.objects.get(pk=user_id)
for service_cls in registry:
for service in service_cls.for_user(user):
service.sync()
# TODO: handle the serialization of a simple ``Exception``
# raised inside the task. Celery is returning:
# EncodeError('Object of type Exception is not JSON
# serializable'). Because of this, the task never ends and the
# FE keeps waiting forever. Also, if we have 3 accounts
# connected and the first one fails, the other two are not
# executed.
try:
service.sync()
except Exception:
pass


sync_remote_repositories = SyncRemoteRepositories()