Refactoring task files #3943
Refactoring task files #3943
Conversation
readthedocs/builds/tasks.py
Outdated
| from readthedocs.restapi.utils import index_search_request | ||
| from readthedocs.search.parse_json import process_all_json_files | ||
| from readthedocs.vcs_support import utils as vcs_support_utils | ||
| from readthedocs.worker import app |
There was a problem hiding this comment.
It looks like almost all of these imports are not used, these should be clean up.
There was a problem hiding this comment.
Yes. I will do that. 👍
readthedocs/builds/tasks.py
Outdated
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| HTML_ONLY = getattr(settings, 'HTML_ONLY_PROJECTS', ()) |
There was a problem hiding this comment.
This doesn't look used either.
|
Hey @agjohnson! I completed refactoring other functions and made changes as you had requested. Could you take a look and let me know if something else needs to be done? |
There was a problem hiding this comment.
Thanks!
Could you please take a look at other places in the code that probably will need to fix the path also?
You can find these places by grepping the code.
Also, @agjohnson we should check the same under the corporate site.
|
Hey @humitos, @agjohnson! I did the changes as you had requested. Could you take a look? |
|
@shubham76 change look good! Could you please solve the conflics by rebasing your branch? After that, could you check if the tests need to be updated also? Thanks! |
|
This has a ton of conflicts in it, so I'm going to close it. It also combined a refactor with some feature additions, where I'd much prefer just a straight refactor, and then an additional PR with additions. Thanks for opening it, but redoing this will probably require a new PR anyway because of all the conflicts. |
This is regarding #3775.
Tried only moving
fileifyfunction as mentioned by @agjohnson here as it operates on versions.Is something like this expected?
I only tried with one function. If things are right here I'll go ahead and make other changes.