Fix up some of the logic around repo and submodule URLs #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was looking for setting DEFAULT_PRIVACY_LEVEL, which wasn't set by default in our settings.
It exists in subclasses, but we should refactor it out anyways.
Use the same RepositoryURLValidator class for all the submodule URLs before performing the sync/update/checkout of them.
* Add conditional logic for submodule relative urls * Break down logic a bit more * Add test case for relative url submodule * Broke test case for invalid url submodule Fixes #3857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3857