Upgrade Elasticsearch to 5.X #3787
Conversation
RichardLitt
added
Design
|
@RichardLitt from my point of view this is ready to review :) |
RichardLitt
added
PR: ready for review
and removed
PR: work in progress
|
Tested it myself with latest master, this on top of it with ES 5.6.8 and worked as expected. |
|
Rebased to latest master and added tests courtesy of @paoloromolini |
xrmx
force-pushed
the
elasticsearch5
branch
2 times, most recently
from
4932508 to
b9145ad
Compare
As elasticsearch expects a long while we have an hash as string. While at it remove references to _parent and _id as they are gone.
fields is now _source and filter should be inside the query. aggs is the new facets and we can drop filtering on aggs as they should be calculated on the query results so after filtering.
You got to start from somwhere
|
@berkerpeksag thanks for the review! updated branch |
|
@ericholscher any chance you can take a look at this? |
| '_source': source, | ||
| } | ||
| if parent: | ||
| doc['_parent'] = parent |
There was a problem hiding this comment.
How the parent child relationship will be made?
There was a problem hiding this comment.
This was breaking in ES5 when I tested it. I think it will require a bit more thought when we move towards ES6, which is a fundamental change in how ES works, so it will require refactoring and thinking about architecture more.
|
@ericholscher you may want to close this too 😿 Still i think some of your preparatory changes can be cherry-picked and pushed separately. |
|
So what will replace this? 😄 |
|
@xrmx agreed. I'm a little sad to not have this work be useful, but ES5->ES6 is a huge change in architecture, and I don't want to keep investing more time into the old code if we can use better abstractions and support ES6. Thanks for the PR though! I'd love to have your help guiding Safwan & the GSOC work, so that we make sure it's useful for everyone. |
This is a rebased and improved version of #3373. Tested with elastic search 5-alpine (ES 5.6.8) docker image. This has received limited testing but project and file search from the main search view and searching from inside the project page search works fine here.