Skip to content

#3741: replaced Go Crazy text with Search #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2018
Merged

#3741: replaced Go Crazy text with Search #3752

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
027f5b3
#3741: replaced Go Crazy text with Search
irkartik Mar 7, 2018
2991c43
#3741: Fixed double quotes typo
irkartik Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/templates/search/base_facet.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<input type="hidden" name="selected_facets" value="{{ selected_facets }}" id='id_selected_facets'>
</div>
<div class="submit-input-wrapper">
<input type="submit" value="{% trans "Go crazy." %}" id="id_search_button">
<input type="submit" value='{% trans "Search" %}' id="id_search_button">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't change the double quotes to single quotes here, html needs ".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"{% trans 'search' %}"
This syntax will do i guess. I think both shall not be double quotes.. Do correct me if i'm wrong

</div>
</form>
</div>
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/templates/search/elastic_project_search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ <h2 class="quiet">Search in this project:</h2>
</div>
<div class="submit-input-wrapper">
{% comment %}Translators: This is about starting a search{% endcomment %}
<input type="submit" value="{% trans "Go crazy." %}">
<input type="submit" value="{% trans 'Search' %}">
</div>
</form>
</div>
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/templates/search/elastic_search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ <h2>Search</h2>
</div>
<div class="submit-input-wrapper">
{% comment %}Translators: This is about starting a search{% endcomment %}
<input type="submit" value="{% trans "Go crazy." %}">
<input type="submit" value='{% trans "Search" %}'>
</div>
</form>
</div>
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/templates/search/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</div>
<div class="submit-input-wrapper">
{% comment %}Translators: This is about starting a search{% endcomment %}
<input type="submit" value="{% trans "Go crazy." %}">
<input type="submit" value='{% trans "Search" %}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you removed the > accidentally here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops.. my bad :D I'll correct it for sure :)

</div>
</form>
</div>
Expand Down