setting stable version manually

readthedocs/projects/forms.py

@@ -328,6 +328,22 @@ def save(self):
             self.project.default_version = default_version
             self.project.save()
 
+        stable_version_identifier = self.cleaned_data.get('stable-version', None)
+        if stable_version_identifier:
+            old_stable_version = self.project.get_stable_version()
+            if old_stable_version:
+                if old_stable_version.identifier != stable_version_identifier:
+                    old_stable_version.identifier = stable_version_identifier
+                    old_stable_version.save()
+                    trigger_build(project=self.project, version=old_stable_version)
+            else:
+                new_stable = self.project.versions.filter(identifier=stable_version_identifier)
+                stable_version = self.project.versions.create_stable(
+                    type=new_stable.type,
+                    identifier=new_stable.identifier)
+                trigger_build(project=self.project, version=stable_version)
+
+
     def save_version(self, version):
         """Save version if there has been a change, trigger a rebuild."""
         new_value = self.cleaned_data.get(
@@ -347,7 +363,6 @@ def save_version(self, version):
         if version.active and not version.built and not version.uploaded:
             trigger_build(project=self.project, version=version)
 
-
 def build_versions_form(project):
     """Versions form with a list of versions and version privacy levels."""
     attrs = {
@@ -356,6 +371,11 @@ def build_versions_form(project):
     versions_qs = project.versions.all()  # Admin page, so show all versions
     active = versions_qs.filter(active=True)
     if active.exists():
+        attrs['stable-version'] = forms.ChoiceField(
+            label=_('Stable Version'),
+            choices=project.get_stable_version_choice(),
+            initial=project.get_default_version(),
+        )
         choices = [(version.slug, version.verbose_name) for version in active]
         attrs['default-version'] = forms.ChoiceField(
             label=_('Default Version'),

readthedocs/projects/models.py

@@ -30,7 +30,7 @@
     RelatedProjectQuerySet)
 from readthedocs.projects.templatetags.projects_tags import sort_version_aware
 from readthedocs.projects.version_handling import (
-    determine_stable_version, version_windows)
+    determine_stable_version, version_windows, sort_versions)
 from readthedocs.restapi.client import api
 from readthedocs.vcs_support.backends import backend_cls
 from readthedocs.vcs_support.utils import Lock, NonBlockingLock
@@ -724,11 +724,20 @@ def supported_versions(self):
     def get_stable_version(self):
         return self.versions.filter(slug=STABLE).first()
 
+    def get_stable_version_choice(self):
+        version_list = self.versions.all()
+        stable_version_choice = sort_versions(version_list)
+        stable_version_choice = [(version_obj.identifier, version_obj.verbose_name)
+                                  for version_obj, comparable in stable_version_choice
+                                  if (not comparable.is_prerelease and version_obj.active)]
+        return stable_version_choice
+
+
     def update_stable_version(self):
         """
         Returns the version that was promoted to be the new stable version.
 
-        Return ``None`` if no update was mode or if there is no version on the
+        Return ``None`` if no update was made or if there is no version on the
         project that can be considered stable.
         """
         versions = self.versions.all()

readthedocs/restapi/views/model_views.py

@@ -178,6 +178,7 @@ def sync_versions(self, request, **kwargs):  # noqa: D205
             )
 
         promoted_version = project.update_stable_version()
+        # promoted version will be none if no update was found.
         if promoted_version:
             new_stable = project.get_stable_version()
             log.info(

readthedocs/templates/projects/project_versions.html

@@ -14,16 +14,19 @@
 {% for field in form %}
 
     {% if forloop.first  %}
-        {# This is a custom form listing the possible active versions, to make 1 the default #}
+        {# This is a custom form listing possible active versions, to select default, stable  #}
+        <h2> {{ field.label }} </h2>
+        {{ field }}
+
+    {% elif forloop.counter0 == 1  %}
         <h2> {{ field.label }} </h2>
         {{ field }}
     <p>
       {% trans "Choose the version that / will redirect to." %}
     </p>
 
     {% else %}
-
-        {% if forloop.counter0 == 1 %}
+        {% if forloop.counter0 == 2 %}
             <h2> {% trans "Choose Active Versions" %} </h2>
             <p>
             {% trans "Active versions below will show up on the site." %}