-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove comments app #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove comments app #3618
Conversation
readthedocs.comments.models.ModerationActionManager is unimplemented. This is a cleanup issue. Closes readthedocs#2879
@shreyateeza so what's the error causing travis to "All checks have failed". Because there are many issues regarding "Comment" app. |
@Tikam02 It means that first the rest issues needs to be merged/closed then only travis-ci will succeed. Right? |
@shreyateeza There is a import error https://travis-ci.org/rtfd/readthedocs.org/jobs/341953589#L844, you should update/delete some tests. |
yup that's what i was referring import error. |
Would love to see someone take this across the finish line, by deleting the tests too! I would love to merge this :) |
@ericholscher I am working on this issue! |
@shreyateeza Glad to hear it! Thank you :) |
@shreyateeza any news on this? We were close to merge it. I'd like to get this done and merged. Please, if you don't have more time to finish it let us know so someone else can continue your work. |
@humitos Yes you can assign this issue to someone else. |
@shreyateeza No need to apologise at all! We're mostly volunteer run, and we all understand. Contribute what you can whenever you can, if you want. :) |
I'm closing this one in favor of #3802 |
readthedocs.comments.models.ModerationActionManager is unimplemented. This is a cleanup issue.
Closes #2879