-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Better autogenerated index file #3447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In this commit 0fcbe84 is the change, the other changes are from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. This looks great.
Two English related things, but I'm not sure if I'm correct.
readthedocs/doc_builder/base.py
Outdated
@@ -101,7 +106,8 @@ def create_index(self, extension='md', **__): | |||
|
|||
This is an autogenerated index file. | |||
|
|||
Please create a ``{dir}/index.{ext}`` or ``{dir}/README.{ext}`` file with your own content. | |||
Please create a ``index.{ext}`` or ``README.{ext}`` file with your own content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be an
here instead of a
since the next word is a vocal.
readthedocs/doc_builder/base.py
Outdated
@@ -101,7 +106,8 @@ def create_index(self, extension='md', **__): | |||
|
|||
This is an autogenerated index file. | |||
|
|||
Please create a ``{dir}/index.{ext}`` or ``{dir}/README.{ext}`` file with your own content. | |||
Please create a ``index.{ext}`` or ``README.{ext}`` file with your own content | |||
under the root directory in your repository (or under ``/docs`` directory). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that this could sound repetitive, so maybe it could be better
under the root (or
/docs
) directory in your repository.
This looks like a good start. We should probably link to some resources that might help folks along, if we really want to make this better. Perhaps our getting started doc guide (http://docs.readthedocs.io/en/latest/getting_started.html)? |
|
||
If you want to use another markup, choose a different builder in your settings. | ||
Check out our `Getting Started Guide | ||
<https://docs.readthedocs.io/en/latest/getting_started.html>`_ to become more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the English is right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
readthedocs/doc_builder/base.py
Outdated
|
||
If you want to use another markup, choose a different builder in your settings. | ||
Check out our `Getting Started Guide | ||
<https://docs.readthedocs.io/en/latest/getting_started.html>`_ to become more | ||
familiar with Read The Docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the Docs
is the brand.
Related issue #3351
Here is how it looks
This image is out of date
