Skip to content

Link to version detail page from build detail page #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Link to version detail page from build detail page #3418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion readthedocs/templates/builds/build_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{% extends "projects/base_project.html" %}

{% load i18n %}
{% load privacy_tags %}
{% load static %}

{% block title %}{{ build.project.name }}{% endblock %}
Expand Down Expand Up @@ -62,7 +63,11 @@

<div class="build-version">
<span class="build-version-slug">
{{ build.version.slug }}
{% if request.user|is_admin:project %}
<a href="{% url "project_version_detail" build.version.project.slug build.version.slug %}">{{ build.version.slug }}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably add an "Edit this version" link, not just link the actual version name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't know where/how to put to not break the style since the commit hash is already between parenthesis (and I like that) so, I was thinking on adding the "Edit this version" in the following line. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example

0.14.4 (acbd8asd67a8761asvsd)
Edit this version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the text link actually. "Edit this version" is a verbose addition. I think working a button into the interface is adding another design pattern to track. I'd rather revisit this when we have a better idea of what design patterns we're using on these interfaces.

{% else %}
{{ build.version.slug }}
{% endif %}
</span>
<span class="build-commit"
data-bind="visible: commit">
Expand Down