Add note about mercurial on tests #3358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the update @stsewd ! |
|
Actually, if we are already requiring this for tests, perhaps we just install mercurial in our testing requirements? @stsewd would you maybe want to change this PR to just install via |
agjohnson
added
the
PR: work in progress
|
Sure, that's better (I didn't know mercurial was written in python D:). |
|
@agjohnson Is it okay if the Mercurial version is not specified? |
|
Normally, it would be fine -- we've been pinning our testing dependencies lately because they break in CI so often though. Pinning to the latest release should be fine |
Some tests need mercurial to pass. Closes readthedocs#3320
This reverts commit 32f2c63.
stsewd
force-pushed
the
add-note-about-mercurial
branch
from
41e02cf to
eca1c5a
Compare
|
@agjohnson Ready, I set the version to the latest (4.4.2) |
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just add a note about mercurial to solve #3320.