Skip to content

Integrate Embed API where we expect it. #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 12, 2017
Merged

Integrate Embed API where we expect it. #3356

merged 5 commits into from
Dec 12, 2017

Conversation

ericholscher
Copy link
Member

This will actually make more of our docs not lies :)

@ericholscher ericholscher requested a review from humitos December 11, 2017 18:51
agjohnson
agjohnson reviewed Dec 12, 2017
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@agjohnson agjohnson merged commit 1a053bd into master Dec 12, 2017
@agjohnson agjohnson deleted the add-embed-api branch December 12, 2017 22:10
@agjohnson agjohnson mentioned this pull request Dec 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson left review comments

@humitos humitos Awaiting requested review from humitos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @agjohnson