Take preferece of tags over branches when selecting the stable version #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to have the same `verbose_name` for different type of versions (for example, '2.0' could both a tag and a branch). If this happen, we want to keep them both. In the UI, it will say just `"2.0"` for the branch and `"2.0 (c0d25453)"` for the tag. This could be improved later if necessary.
humitos
added
PR: ready for review
and removed
PR: work in progress
|
I just updated this PR with more logic on the |
|
@ericholscher I found another place where this PR is kind of related, can you check my commet at #3268 (comment) and give your opinion? |
Now, this logic is like this: - if the project has any Version that is a TAG, the highest version will only be a TAG also (BRANCH are not considered) - if the project doesn't have any TAG the highest version will be a BRANCH (or UNKNOWN in the worst case)
|
I just added one more commit here to follow what it was suggested in the comment and some tests for these scenarios at: bcfbca88 Can you please re-review? :) |
|
Ah yea -- the "version checking" code that is super old and janky :) |
|
That commit looks good! <3 getting these bugs fixed. |
|
Thanks @humitos 👍 |
|
Should be deployed. |
This was referenced Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed a couple of things here.
Let me know if you dislike this from this PR and I will remove them.
The interesting commit with the new logic to take a look is fd0b406
I will add more tests for this new logic.
Closes #3268