Skip to content

Minor improves to import_project_from_live management command #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2017
Merged

Minor improves to import_project_from_live management command #3301

merged 1 commit into from
Nov 27, 2017

Conversation

humitos
Copy link
Member

@humitos humitos commented Nov 22, 2017

  • record the build
  • exclude attributes from API response
  • call UpdateDocsTask with build_id to avoid failing

@humitos
Minor improves to import_project_from_live management command
8434f71 
* record the build
* exclude attributes from API response
* call UpdateDocsTask with `build_id` to avoid failing
agjohnson
agjohnson reviewed Nov 22, 2017
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to wait for tests/lint

@agjohnson agjohnson merged commit 10b3191 into master Nov 27, 2017
@agjohnson agjohnson deleted the humitos/enhancement/import-project branch November 27, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @agjohnson