Add small “ads by” copy to our ads #3256
Conversation
ericholscher
commented
Nov 13, 2017
•
ericholscher
commented
media/css/readthedocs-doc-embed.css
Outdated
| color: #838383; | ||
| font-size: 12px; | ||
| font-style: italic; | ||
| font-family: "Courier"; |
There was a problem hiding this comment.
Would be curious on feedback here. Want something to differentiate it from the ad visually.
There was a problem hiding this comment.
I think it is important to mention that RTD's ads are different from other people's so I like this.
The main part I'd reconsider is hardcoding a font. You might also consider not hardcoding the color but that's less critical. Since this will get displayed on multiple different themes (at least RTD and alabaster) you want the text to stick with the theme and not have the text stick out like a sore thumb to typophiles. I think not changing the font but just making it small, italic, and visually separated would be fine.
Perhaps <p><small><em>Ads served ethically?</em></small></p>?
There was a problem hiding this comment.
Yup, second on font-family change -- there are a lot of Font Things happening, which is good to avoid. The swap to a monospace font is a bit jarring. I think small and italic works just fine, I don't think we have a styling as part of the theme that makes sense to reuse here.
media/css/readthedocs-doc-embed.css
Outdated
| color: #838383; | ||
| font-size: 12px; | ||
| font-style: italic; | ||
| font-family: "Courier"; |
There was a problem hiding this comment.
Yup, second on font-family change -- there are a lot of Font Things happening, which is good to avoid. The swap to a monospace font is a bit jarring. I think small and italic works just fine, I don't think we have a styling as part of the theme that makes sense to reuse here.
|
Updated the screenshots above, should be ready to merge. |
|
Looks good! Needs a rebase now though |
|
@ericholscher Its better to rebase upon master instead of merge. So the log become clean. |
docs/ethical-advertising.rst
Outdated
| and also new companies that care about supporting the open source community. | ||
| Read the Docs is a large, free web service. | ||
| There is one proven business model to support this kind of site: **Advertising**. | ||
| Instead of using en existing ad network, we are building the model we want to exist. |
docs/ethical-advertising.rst
Outdated
| Eric Holscher, | ||
| one of our co-founders also `talks a bit more <http://ericholscher.com/blog/2016/aug/31/funding-oss-marketing-money/>`_ about funding open source this way on his blog. | ||
|
|
||
| Also, Eric Holscher, one of our co-founders also `talks a bit more <http://ericholscher.com/blog/2016/aug/31/funding-oss-marketing-money/>`_ about funding open source this way on his blog. |
There was a problem hiding this comment.
Also repeated very close each other. Not sure if that it's a problem in English or not. Maybe Besides is a replacement for the first Also
There was a problem hiding this comment.
Also is death, killed both of them :D
