Remove donate app from RTD itself
#3184
Conversation
ericholscher
added
the
PR: work in progress
ericholscher
force-pushed
the
add-donate
branch
from
49ab77a to
fa70e22
Compare
| @@ -44,6 +44,7 @@ | |||
| url(r'^accounts/', include('readthedocs.profiles.urls.private')), | |||
| url(r'^accounts/', include('allauth.urls')), | |||
| url(r'^notifications/', include('readthedocs.notifications.urls')), | |||
| url(r'^accounts/gold/', include('readthedocs.gold.urls')), | |||
There was a problem hiding this comment.
Other question is do we move Gold out as well, and keep it gated in a similar way?
There was a problem hiding this comment.
Eventually, +1 from me. We can address this separately. Feel free to open a ticket to track the work.
There was a problem hiding this comment.
Just gave this a quick glance due to 100% deletes and size. We should make sure dependencies are removed and added to the setup.py in ext, along with any other missing depends. There are probably a number of depends that are just coming from rtfd/readthedocs.org requirements.
|
|
||
| from __future__ import absolute_import | ||
| from django.db import models, migrations | ||
| import django_countries.fields |
There was a problem hiding this comment.
Can we remove this dependency? We can probably move this to the ext repo if so.
| PROMO_GEO_PATH = getattr(settings, 'PROMO_GEO_PATH', None) | ||
|
|
||
| if PROMO_GEO_PATH: | ||
| import geoip2.database # noqa |
There was a problem hiding this comment.
Believe that is installed via ops.
|
🎆 |
ericholscher
removed
the
PR: work in progress
This splits out the
donateapp from RTD, so that we don't ship our ad code to all the OSS users who don't care about it.The actual changes are at the bottom, just some URL adjustments.