Refactor project documentation syncing tasks #3143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the syncing tasks to execute in a guaranteed fashion. Before this change, it was possible for broadcast tasks and symlink deletion tasks to execute concurrently. This changes all the broadcast task calls into function calls from a singular broadcast task. In more detail: * The `finish_build` task was executed as a task from the webs, and kicked off broadcast tasks to update files. Instead, Version update operations were move to the build process, through the API. The webs only the one broadcast task * Version API was given the same APIRestrictedPermission as other end points, it can now be updated by staff
agjohnson
added
the
PR: work in progress
ericholscher
approved these changes
Oct 4, 2017
|
I guess because we only want them to happen once? |
|
Yeah, i suppose we only want them to happen once. There is certainly a better pattern here, using Celery chains[1] or something eventually. I actually wonder if this causing problems on webs already, where downloads and search are updated concurrently to the file syncing tasks. Seems it would be. I can polish up my celery test branch, there wasn't much to the upgrade, and it buys us some flexibility in task execution. 1: http://docs.celeryproject.org/en/latest/userguide/canvas.html#chains |
agjohnson
removed
the
PR: work in progress
ericholscher
pushed a commit
that referenced
this pull request
Oct 9, 2017
This updates the syncing tasks to execute in a guaranteed fashion. Before this change, it was possible for broadcast tasks and symlink deletion tasks to execute concurrently. This changes all the broadcast task calls into function calls from a singular broadcast task. In more detail: * The `finish_build` task was executed as a task from the webs, and kicked off broadcast tasks to update files. Instead, Version update operations were move to the build process, through the API. The webs only the one broadcast task * Version API was given the same APIRestrictedPermission as other end points, it can now be updated by staff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the syncing tasks to execute in a guaranteed fashion. Before this
change, it was possible for broadcast tasks and symlink deletion tasks to
execute concurrently. This changes all the broadcast task calls into function
calls from a singular broadcast task.
In more detail:
finish_buildtask was executed as a task from the webs, and kicked offbroadcast tasks to update files. Instead, Version update operations were move
to the build process, through the API. The webs only the one broadcast task
can now be updated by staff