Skip to content

added support for selecting per-project Python interpreter used to create the virtual environment. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2012

Conversation

yeiniel
Copy link
Contributor

@yeiniel yeiniel commented Dec 14, 2012

This is a solution for Issue 132. Maybe you recall I comment on the issue thread that i will try to solve the issue, well this is my solution. The only problem is that my machine OS is Debian and the environment is not created once a new project is added, may be you can test that part. Is very simple. The project model is updated to store the name of the interpreter used to create the virutal environment. The interpreter name is one of the choices set on constants for that application. The project import form has been modified too to make the Python interpreter selectable and the import project task has been modified to spell explicitly the name of the interpreter on the environment creation command. Additionally a migration has been added to make easy the database schema update.

…er used to create the project virtual environment. The import project form is modified and the PYTHON_CHOICES constant corrected.
@ericholscher
Copy link
Member

This looks like a great start. I think we'll call it python2 and python3, where python->python2. This is more explicit. I'll go ahead and give this a test locally and see if it works. I'm curious if Sphinx and everything else will install properly.

@ericholscher
Copy link
Member

Hitting this bug when trying to test this functionality: pypa/pip#650

It seems pip can't install distribute on py3k :/ This is likely to hold up using it on RTD as it breaks the virtualenv option. Looking at possible ways to work around it.

@ericholscher
Copy link
Member

Looks like we get basic support if we don't enable the upgrade flag with pip and distribute.

ericholscher added a commit that referenced this pull request Dec 18, 2012
@ericholscher ericholscher merged commit 497f50c into readthedocs:master Dec 18, 2012
@yeiniel
Copy link
Contributor Author

yeiniel commented Dec 18, 2012

I have a question. Where this feature will be available on readthedocs?

best regards
Yeiniel

@yeiniel
Copy link
Contributor Author

yeiniel commented Dec 18, 2012

sorry to ask before test. i see that there is available righ now.

again, sorry
Yeiniel

@yeiniel
Copy link
Contributor Author

yeiniel commented Dec 18, 2012

I testit and don't work. the reason is that you have to install virtualenv in all the interpreters for this to work because the virtualenv command is run with the -m schitch on the interpreter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants