Document binary files for no line ending changes #3081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.gitattributes
file from #3053 caused some issues on a clean clone of the repository for me. These issues involved modifying the line endings of binary files and manifested themselves in the form of binary files showing as modified ingit status
with warnings like:At first I was very confused as I would think CRLF endings were only for Windows users. However, I realized that binary files could contain CRLFs. When I looked at the
.gitattributes
file, it denotes everything as text with Unix line endings. Based on github's useful docs on the subject, I think that documenting binary files will clear this up.STEPS TO REPRODUCE
For me, a fresh clone of the latest master would immediately show files as modified.
SYSTEM INFORMATION
OS: MacOS 10.12.6
Git: 2.14.1