Fixes py27 django 1.10 dep warnings in core subdomain urls. #3047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 17, 2017 10:32
Django 1.10 doesn't like using patterns('', ...) and instead
wants the use of a list. It also no longer wants the string path
to a callable and instead wants the callable itself.
Django 1.10 wants urls to have the view they are passed as a callable. In addition, the view didn't define server_error, it only defined server_error_500. Switched to using that.
handler404 and handler500 were being passed as strings rather than as callables
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.10 doesn't like using patterns('', ...) and instead
wants the use of a list. It also no longer wants the string path
to a callable and instead wants the callable itself.