Fix bug with symlink creation #3028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
reviewed
Aug 2, 2017
readthedocs/core/symlink.py
Outdated
| # TODO this should use os.symlink, not a call to shell. For now, | ||
| # this passes command as a list to be explicit about escaping | ||
| # spaces. | ||
| status, _, stderr = run(['ln', '-nsf', docs_dir, symlink]) |
There was a problem hiding this comment.
All of the other calls in this file seem to not pass a list here. Should those be fixed, too?
There was a problem hiding this comment.
Might as well. I'll push up some cleanup and fix some of those too
Previously, this was executing a command using a shell, but without properly escaping the input. This instead passes a list in to Popen, to ensure escape is working properly.
agjohnson
force-pushed
the
fix-subproject-symlink
branch
from
ddb8037 to
06cb5fd
Compare
|
I updated this to also change the rest of the symlink calls and refactor out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this was executing a command using a shell, but without properly
escaping the input. This instead passes a list in to Popen, to ensure escape is
working properly.