Add eslint using the airbnb config. #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to make the JS consistent, this adds an ESLint gulp task. ESLint is *very* configurable, and has no defaults. Instead, this reaches for airbnb's legacy config (which covers ES5), which is one of the most popular configurations. As a last step, it turns off all of the rules which currently fail. We can turn them on piecemeal, or override the airbnb style to use a different format. Rules to prioritize (as they likely indicate bugs): * "array-callback-return": "off", * "eqeqeq": "off", * "guard-for-in": "off", * "no-inner-declarations": "off", * "no-loop-func": "off", * "no-mixed-operators": "off", * "no-undef": "off", * "no-use-before-define": "off", * "one-var": "off",
This adds an ESLint step to the CI service so we prevent unlinted code from making its way in.
|
This is great! Thanks for this. I'll let @agjohnson look over it since he owns most of the front end, but I think this is a solid step forward. |
|
I wonder if we can add this to tox, during the lint step? I don't know if it has a good support for installing JS deps, but it would be useful to be able to run it locally. |
By adding a tox env for eslint, we allow users to run it locally as part of tox runs. Thanks for the suggestion @ericholscher!
|
Thanks @agjohnson . I've been going down a rabbit hole of tox configurations to try to avoid setting up a whole python env, but I'm pleased with this state. |
|
Great, yeah this is a solid addition. I've opened up #2909 to actually address the linting rules to a stricter level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make the JS consistent, this adds an ESLint gulp task. ESLint
is very configurable, and has no defaults. Instead, this reaches for
airbnb's legacy config (which covers ES5), which is one of the most popular
configurations. As a last step, it turns off all of the rules which currently
fail. We can turn them on piecemeal, or override the airbnb style to use a
different format.
Rules to prioritize (as they likely indicate bugs):
Also adds to CI, though I didn't come up with a great strategy to separate execution from the Python tests. This means that ESLint is running once per Travis configuration...