Fix lint issues for privacy app #2888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
May 23, 2017
| @@ -8,12 +14,17 @@ | |||
| log = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| # The file builting was removed in Python 3, so we should not use it | |||
| # Setting to None here to silence pylint for this builtin only | |||
| file = None # pylint: disable=redefined-builtin | |||
There was a problem hiding this comment.
Perhaps instead this should just rename the file argument on the various copy methods to not use a builtin. A quick search shows this as the only mention of the file argument:
There was a problem hiding this comment.
That was my first thought, but I wasn't sure if my searches were finding everything. I'll go ahead and do this.
fmoor
pushed a commit
to fmoor/readthedocs.org
that referenced
this pull request
May 24, 2017
* Fix lint issues for privacy app * Rename file param to Syncers * Roll back comment change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.