Skip to content

linting core app #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

linting core app #2887

wants to merge 2 commits into from

Conversation

smcoll
Copy link
Contributor

@smcoll smcoll commented May 22, 2017

IN PROGRESS

What types of exceptions are we actually trying to catch in these cases?

core/forms.py
  Line: 30
    pylint: bare-except / No exception type(s) specified (col 8)

core/management/commands/reindex_elasticsearch.py
  Line: 43
    pylint: bare-except / No exception type(s) specified (col 12)

core/templatetags/core_tags.py
  Line: 66
    pylint: lost-exception / return statement in finally block may swallow exception (col 12)

Any opinions on how to handle these cases?

core/resolver.py
  Line: 53
    pylint: unused-argument / Unused argument 'private' (col 41)
  Line: 122
    pylint: unused-argument / Unused argument 'private' (col 38)

core/utils/tasks/public.py
  Line: 27
    pylint: unused-argument / Unused argument 'request' (col 30)
    pylint: unused-argument / Unused argument 'state' (col 39)
    pylint: unused-argument / Unused argument 'context' (col 46)

@agjohnson agjohnson modified the milestone: Cleanup May 22, 2017
@agjohnson agjohnson added PR: work in progress Pull request is not ready for full review and removed PR: ready for review labels May 23, 2017
@agjohnson
Copy link
Contributor

If anyone wants to pick this PR up, feel free. @smcoll said he would try to return to this later if not.

@agjohnson
Copy link
Contributor

Moved this to #2911 to finish up work on a different branch.

@agjohnson agjohnson closed this May 25, 2017
@agjohnson agjohnson removed the PR: work in progress Pull request is not ready for full review label May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants