Skip to content

Fix lint issues for notifications app #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2017
Merged

Fix lint issues for notifications app #2881

merged 3 commits into from
May 23, 2017

Conversation

lordmauve
Copy link
Contributor

  • Add module docstrings.
  • Rename object named arg to context_object in Notification.__init__() to avoid shadowing object
  • Eliminate some unused imports
  • add __all__ in __init__.py to indicate imports are intended to be re-exposed

@agjohnson agjohnson modified the milestone: Cleanup May 22, 2017
@agjohnson
Copy link
Contributor

Looks good! 👍 on the expanded documentation for everything too, it's much more helpful.

@agjohnson agjohnson merged commit a2cf44b into readthedocs:master May 23, 2017
fmoor pushed a commit to fmoor/readthedocs.org that referenced this pull request May 24, 2017
@lordmauve @fmoor
Fix lint issues for notifications app (readthedocs#2881)
8722701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Cleanup
Development

Successfully merging this pull request may close these issues.
2 participants
@lordmauve @agjohnson