linting for the api module #2870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
May 22, 2017
readthedocs/api/base.py
Outdated
| @@ -207,7 +216,7 @@ def override_urls(self): | |||
| name="api_get_anchor"), | |||
| ] | |||
|
|
|||
| def get_anchor(self, request, **kwargs): | |||
| def get_anchor(self, request): | |||
There was a problem hiding this comment.
I'll want to double check that kwargs is not required by anything that we override with
There was a problem hiding this comment.
i just replaced that with `**__`` instead
readthedocs/api/utils.py
Outdated
| @@ -70,14 +71,15 @@ def _url_template(self, query, selected_facets): | |||
| }) | |||
| return url_template + '?' + query_string | |||
|
|
|||
| def _search(self, request, model, facets=None, page_size=20, | |||
| def _search(self, request, model, facets=None, page_size=20, # pylint: disable=too-many-locals | |||
There was a problem hiding this comment.
This could go on L75 or on a separate line after that I believe, to not break up args with a comment
There was a problem hiding this comment.
Didn't know that could be done; thanks.
readthedocs/api/utils.py
Outdated
| @@ -154,7 +159,7 @@ def is_authenticated(self, request, **kwargs): | |||
|
|
|||
|
|
|||
| class EnhancedModelResource(ModelResource): | |||
| def obj_get_list(self, request=None, *args, **kwargs): | |||
| def obj_get_list(self, request=None, **kwargs): | |||
There was a problem hiding this comment.
Though not used here, we should also ensure args was not used or required. For instance, if ModelResource has additional positional arguments.
…modate potential current usages
fmoor
pushed a commit
to fmoor/readthedocs.org
that referenced
this pull request
May 24, 2017
* linting for the api module * restore positional arguments, even thought they're discarded, to accomodate potential current usages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.