Skip to content

Resolve linting issues in the vcs_support app. #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2017
Merged

Resolve linting issues in the vcs_support app. #2868

merged 1 commit into from
May 22, 2017

Conversation

cmc333333
Copy link
Contributor

  • Docstrings
  • Rename unused vars to _
  • Delay logging formatting
  • Catch a specific exception <- Would love a second set of eyes here

@agjohnson
Copy link
Contributor

Looks good to me!

Refs #2838

@agjohnson agjohnson merged commit 1704825 into readthedocs:master May 22, 2017
fmoor pushed a commit to fmoor/readthedocs.org that referenced this pull request May 24, 2017
@cmc333333 @fmoor
Resolve linting issues in the vcs_support app. (readthedocs#2868)
a9a996f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmc333333 @agjohnson