Switch all uses of print to be a function, not a statement #2841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should ever have print statements in our code at all. Either the string should be logged properly or if it's debug data, just removed. |
agjohnson
added
PR: work in progress
|
I'm going to close this PR because #2819 is closer to being merged and is larger. I'm trying to reduce the number of conflicts stemming from merging that. Feel free to create a PR that removes the print statements however! |
agjohnson
removed
the
PR: work in progress
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up from Eric’s comment on #2819, this patch converts every use of
printas a statement to beprint()as a function.Aimed at improving eventual Python 3 compatibility, without breaking anything on Python 2.7.
There is a pylint check for print-statement, but (1) I couldn't get it working, and (2) it wants you to add
from __future__ import print_functioneverywhere, which is a bigger patch.