Skip to content

Allow pillow to float version in conda builds #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Apr 3, 2017

Closes #2778

@ericholscher
Copy link
Member

Looks good. We should have a larger conversation about unpinning all our conda deps, but I can unblock you for now :)

@ericholscher ericholscher merged commit bc60531 into readthedocs:master Apr 5, 2017
@ericholscher
Copy link
Member

Will probably be a day or two before it gets deployed.

@willingc
Copy link
Contributor Author

willingc commented Apr 5, 2017

Thanks @ericholscher.

@willingc willingc deleted the iss-2778 branch April 5, 2017 16:12
@anntzer
Copy link

anntzer commented Apr 10, 2017

Please notify here when this gets deployed (apparently not the case yet). Thanks!

@ericholscher
Copy link
Member

ericholscher commented Apr 10, 2017 via email

@anntzer
Copy link

anntzer commented Apr 10, 2017

Well, you apparently also need to unpin sphinx_rtd_theme at least (https://readthedocs.org/projects/mplcursors/builds/5271935/) :-)

@willingc
Copy link
Contributor Author

Hi @anntzer,

You should be able to modify your environment.yml:

https://github.com/anntzer/mplcursors/blob/master/environment.yml#L4

to install sphinx_rtd_theme such as we do here:

https://github.com/jupyterhub/jupyterhub/blob/master/docs/environment.yml#L14

@anntzer
Copy link

anntzer commented Apr 10, 2017

Thanks for the pointer, it is helpful as a workaround. But really this should be fixed at the level of RTD, no?

@willingc
Copy link
Contributor Author

Actually, looking at it closer there will still likely be a mismatch depending on Python version used. Probably does make sense to unpin. Overall, we should have a discussion with the conda folks to come up with sensible defaults. cc @ericholscher

@ericholscher
Copy link
Member

Yea, I'd really like to have more folks involved with conda on our core team, so that we can make sure we handle this properly. Nobody on our core team actively uses conda, so it's hard for us to support it.

@willingc
Copy link
Contributor Author

That makes sense @ericholscher. I'll see who I can round up and worst case we will find them at PyCon ;-) Bummed to be missing WTD but my daughter is graduating from college 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants