-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Allow pillow to float version in conda builds #2779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good. We should have a larger conversation about unpinning all our conda deps, but I can unblock you for now :) |
Will probably be a day or two before it gets deployed. |
Thanks @ericholscher. |
Please notify here when this gets deployed (apparently not the case yet). Thanks! |
Should be deployed now.
…On Mon, Apr 10, 2017 at 11:25 AM, Antony Lee ***@***.***> wrote:
Please notify here when this gets deployed (apparently not the case yet).
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2779 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABjprdY9Rct-3jzGyrfE0jc04fIsoQ1ks5runQjgaJpZM4MyKHm>
.
--
Eric Holscher
Maker of the internet residing in Portland, Oregon
http://ericholscher.com
|
Well, you apparently also need to unpin sphinx_rtd_theme at least (https://readthedocs.org/projects/mplcursors/builds/5271935/) :-) |
Hi @anntzer, You should be able to modify your environment.yml: https://github.com/anntzer/mplcursors/blob/master/environment.yml#L4 to install sphinx_rtd_theme such as we do here: https://github.com/jupyterhub/jupyterhub/blob/master/docs/environment.yml#L14 |
Thanks for the pointer, it is helpful as a workaround. But really this should be fixed at the level of RTD, no? |
Actually, looking at it closer there will still likely be a mismatch depending on Python version used. Probably does make sense to unpin. Overall, we should have a discussion with the conda folks to come up with sensible defaults. cc @ericholscher |
Yea, I'd really like to have more folks involved with conda on our core team, so that we can make sure we handle this properly. Nobody on our core team actively uses conda, so it's hard for us to support it. |
That makes sense @ericholscher. I'll see who I can round up and worst case we will find them at PyCon ;-) Bummed to be missing WTD but my daughter is graduating from college 🎉 |
Closes #2778