Add a bit more color to the promo display. #2770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
added
PR: work in progress
ericholscher
added
PR: ready for review
and removed
PR: hotfix
agjohnson
approved these changes
Apr 14, 2017
| {{ promo.report_html_text|safe }} | ||
| </div> | ||
|
|
||
| <br> |
There was a problem hiding this comment.
So, this is not necessarily an issue that requires changes, but the main problem with our UI and templates is lack of consistency, so I'll point out that:
- The styling you are looking for is closer to a
<dl>, instead of recreating this with a paragraph tag <strong>isn't used semantically here. The<strong>text here is structural and should be handled with a general list that styles the label and value in a generic way.- We should never need
<br>in our templates, whitespace should be left to CSS. We can't remove<br>using CSS, so this makes for noise when restyling.
This is just informational. I'm still planning out what a UI overhaul will be, I'd like to stop collecting debt here in the meantime though.
There was a problem hiding this comment.
Went ahead and updated it 👍
This is primarily used so we can send email to folks using alabaster, and other themes we might want to display ads on. This will allow us to give people fair warning before we put ads on their docs.
ericholscher
force-pushed
the
promo-filter-updates
branch
from
87ad9fe to
c6bf143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds: