Center 404 copy in a janky way :) #2768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
added
PR: work in progress
agjohnson
requested changes
Mar 30, 2017
| @@ -11,6 +11,7 @@ | |||
| {% endblock %} | |||
|
|
|||
| {% block content %} | |||
| <div style="margin-left: auto; margin-right: auto; width: 900px; text-align: center"> | |||
There was a problem hiding this comment.
We shouldn't be putting inline styles into templates, and the width shouldn't be set at a static width here.
There was a problem hiding this comment.
That seems to go against the goal of keeping the donate stuff as it's own app? I think it probably makes sense for a small use-case like this.
There was a problem hiding this comment.
These rules don't need to be brought into core.css if they are specific to just this use case. A simple CSS include from a file in donate/static works. Inline styles should always be avoided as CSS can't be overhauled without sifting through templates on top of CSS.
There was a problem hiding this comment.
True, that was pretty simple.
How should I fix the width?
ericholscher
removed
the
PR: work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.