Skip to content

Force unicode on verison string #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2017
Merged

Force unicode on verison string #2767

merged 1 commit into from
Mar 31, 2017

Conversation

ericholscher
Copy link
Member

No description provided.

@ericholscher ericholscher added PR: work in progress Pull request is not ready for full review PR: hotfix Pull request applied as hotfix to release PR: ready for review and removed PR: work in progress Pull request is not ready for full review labels Mar 30, 2017
agjohnson
agjohnson approved these changes Mar 30, 2017
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense, but I'm not sure what this is addressing without a description on the PR

@ericholscher
Copy link
Member Author

Passing a string in instead of unicode caused it to error

@ericholscher ericholscher merged commit e9bec3e into master Mar 31, 2017
@stsewd stsewd deleted the fix-unicode-handling branch August 15, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @agjohnson