Fix issue where we can't find conf.py and raise bad error. #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing users with invalid conf.py file settings
to get an "unknown error" message.
This was the traceback that was fixed:
```
Feb 7 20:55:41 build01 readthedocs/readthedocs.doc_builder.environments[32422]: ERROR (Build) [flowframework:latest] Conf File Missing. Please make sure you have a conf.py in your project. [readthedocs.doc_builder.environments:306]
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/readthedocs/projects/tasks.py", line 170, in run
outcomes = self.build_docs()
File "/home/docs/checkouts/readthedocs.org/readthedocs/projects/tasks.py", line 331, in build_docs
outcomes['html'] = self.build_docs_html()
File "/home/docs/checkouts/readthedocs.org/readthedocs/projects/tasks.py", line 348, in build_docs_html
html_builder.append_conf()
File "/home/docs/checkouts/readthedocs.org/readthedocs/doc_builder/backends/sphinx.py", line 68, in append_conf
outfile_path = project.conf_file(self.version.slug)
File "/home/docs/checkouts/readthedocs.org/readthedocs/projects/models.py", line 539, in conf_file
u"Conf File Missing. Please make sure you have a conf.py in your project.")
ProjectImportError: Conf File Missing. Please make sure you have a conf.py in your project
```
ericholscher
added
the
PR: work in progress
agjohnson
approved these changes
Feb 7, 2017
ericholscher
removed
the
PR: work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing users with invalid conf.py file settings
to get an "unknown error" message.
This was the traceback that was fixed: