Skip to content

Clean up documentation #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 13, 2017
Merged

Clean up documentation #2578

merged 11 commits into from
Jan 13, 2017

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jan 5, 2017

Performs some spring-cleaning of the documentation, including:

  • Deleting outdated GSoC 2014 page
  • Fixing some section header depth warnings
  • Adding some more documentation to index.rst (and thereby the sidenav)
  • Removing references to things which no longer exist

This removes two management commands (import_intersphinx and sync_builds) which no longer work and cannot be imported, because they rely on code which has already been deleted.

@agjohnson agjohnson added PR: ready for review PR: work in progress Pull request is not ready for full review and removed PR: ready for review labels Jan 5, 2017
@lukegb
Copy link
Contributor Author

lukegb commented Jan 5, 2017

These commits at least make make html warning-free (apart from the docstring from builds.models.Version), which is almost in Numpy docstring format (but is, afaict, the only class documented in such a way). I'll think about that one.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, have a couple comments/questions.

@@ -7,7 +7,7 @@ We pull your code from your Subversion_, Bazaar_, Git_, and Mercurial_ repositor
Then we build documentation and host it for you.
Think of it as *Continuous Documentation*.

The code is open source, and `available on github`_.
The code is open source, and `available on GitHub`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a link, so the link text should be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch. Thanks.

class Command(BaseCommand):
def handle(self, *args, **options):
for version in Version.objects.filter(slug=LATEST):
update_intersphinx(version.pk)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason these files got deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per b9a7eb6 and 8adb983, these both rely on code that was deleted in 2014 (see the commit message, I'll add it to the PR description too), so they don't even import without throwing an error any more.

autodoc was trying to import them and throwing warnings.

lukegb added 11 commits January 12, 2017 13:14
This ran haystack.autodiscover(), which was obsoleted by Haystack 2.0.0.
In addition, search_sites itself was removed by Haystack 2.0.0
(HAYSTACK_SITECONF).
The task it refers to was removed in
bf1a3d2, way back in 2014.
It refers to readthedocs.core.utils.copy_to_appservers, which was
removed in 3c7f166, way back in 2014.
ops-docs previously removed in 105c566.
This uses Sphinx-style #: doc-comments, to retain a semblance of the
current behaviour.
@ericholscher
Copy link
Member

Thanks for this!

@ericholscher ericholscher merged commit 6b30a12 into readthedocs:master Jan 13, 2017
@ericholscher ericholscher removed the PR: work in progress Pull request is not ready for full review label Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants