-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add support for Pip's extra dependencies in YAML config. #2368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,14 +44,18 @@ def install_package(self): | |
setup_path = os.path.join(self.checkout_path, 'setup.py') | ||
if os.path.isfile(setup_path) and self.config.install_project: | ||
if self.config.pip_install or getattr(settings, 'USE_PIP_INSTALL', False): | ||
extra_req_param = '' | ||
if self.config.extra_requirements: | ||
extra_req_param = '[{0}]'.format( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. {0} -> {} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Even if I can find a couple of Should I switch back to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd say go with the current There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK good. |
||
','.join(self.config.extra_requirements)) | ||
self.build_env.run( | ||
'python', | ||
self.venv_bin(filename='pip'), | ||
'install', | ||
'--ignore-installed', | ||
'--cache-dir', | ||
self.project.pip_cache_path, | ||
'.', | ||
'.{0}'.format(extra_req_param), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. {0} -> {} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question as #2368 (comment). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As decided in #2368 (comment) , we'll keep the |
||
cwd=self.checkout_path, | ||
bin_path=self.venv_bin() | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here:
additionnaly