Skip to content

Fixed build results page on firefox #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed build results page on firefox #2350

wants to merge 1 commit into from

Conversation

shubheksha
Copy link
Contributor

Fixes #2261

@agjohnson agjohnson self-assigned this Oct 4, 2016
@agjohnson agjohnson added the PR: work in progress Pull request is not ready for full review label Oct 4, 2016
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I raised an issue against this fix in the attached issue, this will need some more testing for a proper fix. I've taken this for now, but anyone that can test for a proper firefox fix is welcome to chime in.

@jaraco
Copy link
Contributor

jaraco commented Feb 3, 2017

@agjohnson: My feeling is that the fix, while imperfect, at least makes the site usable on Firefox and Chrome, whereas currently it's only usable on Chrome. Would you consider accepting this fix as a temporary measure, and then we could create a follow-up issue to address the aesthetic issue in Chrome?

@jaraco
Copy link
Contributor

jaraco commented Feb 3, 2017

Digging into this a little deeper, this margin: -16px really feels like a hack for defective rendering in Chrome. Without it, Chrome is adding an ugly amount of whitespace to the span.

@agjohnson
Copy link
Contributor

Indeed, see the attached #2261 for more background here

@agjohnson
Copy link
Contributor

Closing this PR, there is a new PR open addressing the review changes above.

@agjohnson agjohnson closed this Feb 7, 2017
@agjohnson agjohnson removed the PR: work in progress Pull request is not ready for full review label Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants