Skip to content

Use cname_to_slug() helper in SubdomainMiddleware #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2016
Merged

Use cname_to_slug() helper in SubdomainMiddleware #2317

merged 1 commit into from
Jul 18, 2016

Conversation

berkerpeksag
Copy link
Member

No description provided.

@berkerpeksag berkerpeksag mentioned this pull request Jul 17, 2016
Closed
@agjohnson
Copy link
Contributor

This makes sense to me. @ericholscher any reason to avoid this change?

@ericholscher
Copy link
Member

LGTM.

@ericholscher ericholscher merged commit 8bb2c3b into readthedocs:master Jul 18, 2016
@berkerpeksag berkerpeksag deleted the use-cname-helper branch September 27, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berkerpeksag @agjohnson @ericholscher