Speed up build process #2312
Merged
Speed up build process #2312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we do need deps on linting, otherwise get swamped with import errors on external modules. +1 on removing runtests.sh -- if our docs still reference this, we should update that. Also, yeah, not using coveralls, +1 there too. |
agjohnson
added
Status: reviewed
PR: work in progress
* We don't need all dependecies to run 'tox -e lint' * We don't really use pytest-django but it wouldn't hurt setting --reuse-db * coveralls doesn't seem to be working at the moment so I removed it * Delete unused runtests.sh. 'tox -e py27' already does the same job. * Cache all dependencies in Travis CI
|
Thanks for the review. Updated PR. |
|
Great, thanks for the update! Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting --reuse-db
I removed it
the same job.