Fix AttributeError error at /api/v1/file/search/ #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, /api/v1/file/search/ is not working because of django-haystack/django-haystack#908 See #2264 for a complaint about the broken endpoint. The problem has already been fixed in django-haystack/django-haystack@4956486 I have just upgraded django-haystack and django-tastypie dependencies to fix the problem.
|
Sounds good. We should likely remove the tastypie dependency, because we currently use Elastic Search for our main search functionality, and deprecate the v1 search. This is a good fix for now, though. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, /api/v1/file/search/ is not working because
of django-haystack/django-haystack#908
See #2264 for a
complaint about the broken endpoint.
The problem has already been fixed in django-haystack/django-haystack@4956486
I have just upgraded django-haystack and django-tastypie
dependencies to fix the problem.