Skip to content

Update donate page with timeless info #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2016
Merged

Update donate page with timeless info #2300

merged 4 commits into from
Aug 13, 2016

Conversation

ericholscher
Copy link
Member

Currently we still have our old fundraiser on the donate page.
We should make this evergreen,
and allow folks to donate at any time.

Currently we still have our old fundraiser on the donate page.
We should make this evergreen,
and allow folks to donate at any time.
@ericholscher
Copy link
Member Author

Can't find a good way to make the donate buttons look reasonably good, they float left all the way down.

@agjohnson
Copy link
Contributor

@ericholscher i can pull this and patch it up, might be able to resolve with a screenshot though

@agjohnson
Copy link
Contributor

Also, instead of removing functionality for the donation drive in the templates, and requiring us to do the work again if we do another drive in the future, perhaps the more correct thing to do is add state to the template that conditionally shows either the 'evergreen' display, or a donation drive with progress bar.

@ericholscher
Copy link
Member Author

Yea, I started to add things to the Evergreen section, but can put that back in with conditionals.

@ericholscher
Copy link
Member Author

unspecified

Shows the CSS issue.

@agjohnson
Copy link
Contributor

Okay, makes sense. The progress bar was removed. Need to reformat things or add some content. I can take a look.

@agjohnson agjohnson self-assigned this Jul 14, 2016
@agjohnson agjohnson added PR: work in progress Pull request is not ready for full review and removed PR: ready for review labels Jul 14, 2016
@ericholscher
Copy link
Member Author

Another option is to set an amount for the year, and keep ad money that comes in as part of this count to be transparent about all of our income.

@agjohnson agjohnson merged commit 9013d23 into master Aug 13, 2016
@agjohnson agjohnson deleted the donate-updates branch August 13, 2016 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants